[Lldb-commits] [PATCH] D56511: [Python] Update PyString_FromString() to work for python 2 and 3.
Zachary Turner via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jan 9 14:12:42 PST 2019
zturner accepted this revision.
zturner added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/scripts/Python/python-wrapper.swig:827
PyObject *arg = SBTypeToSWIGWrapper(frame_sb);
This looks like another possible object leak. The documentation for `PyObject_CallMethodObjArgs` doesn't mention whether it takes ownership of the argument, but I think it wouldn't make sense for it to do so, because you're just calling a function. In any case, just make sure the current change doesn't regress the test suite.
CHANGES SINCE LAST ACTION
More information about the lldb-commits