[Lldb-commits] [PATCH] D56440: [CMake] Phase out LLDB_TEST_C/CXX_COMPILER in favor of single LLDB_TEST_COMPILER

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 9 12:14:11 PST 2019


xiaobai added inline comments.


================
Comment at: CMakeLists.txt:72
   endif()
+  if (compiler_used)
+    set(LLDB_TEST_COMPILER_USED ${compiler_used})
----------------
Is this check needed? `compiler_used` should be set always here because of the way the above block is written.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56440/new/

https://reviews.llvm.org/D56440





More information about the lldb-commits mailing list