[Lldb-commits] [PATCH] D56462: Change SymbolFile::ParseTypes to ParseTypesForCompileUnit

[Adrian McCarthy via Phabricator via lldb-commits]

amccarth added a comment.

So this Patch is effectively NFC, since no caller (not even a test) was using the functionality you've removed.  Seems like a nice refactor.



================
Comment at: lldb/source/Core/Module.cpp:382
 
       // Parse all types for this compile unit
+      symbols->ParseTypesForCompileUnit(*sc.comp_unit);
----------------
I'd argue that this comment is now obsolete.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56462/new/

https://reviews.llvm.org/D56462