[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

Wed Jan 9 06:48:09 PST 2019

labath added inline comments.

================
Comment at: lit/Minidump/Windows/Sigsegv/sigsegv.test:6
+CHECK: * thread #1, stop reason = Exception 0xc0000005 encountered at address 0x7ff7a13110d9
+CHECK:   * frame #0: 0x00007ff7a13110d9 sigsegv.exe`crash at sigsegv.cpp:22
+
----------------
teemperor wrote:
> This test fails for me because lldb is picking up my custom lldbinit (which changes the format of the frame output). Not sure what's the right way to fix it, but setting a custom fixed frameformat in the sigsegv.lldbinit seems like an obvious solution.
Are you sure you have the right patch here?

Regardless, I actually think the right solution would be to pass `--no-lldb-init` as a part of the `%lldb` substitution (I'm surprised we don't do that already) to make sure **no** test sources random commands from users' .lldbinit files.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55142/new/

https://reviews.llvm.org/D55142