[Lldb-commits] [PATCH] D56440: [CMake] Phase out LLDB_TEST_C/CXX_COMPILER in favor of single LLDB_TEST_COMPILER

Wed Jan 9 06:13:05 PST 2019

sgraenitz added a comment.

In D56440#1349892 <https://reviews.llvm.org/D56440#1349892>, @JDevlieghere wrote:

> It looks like `LLDB_TEST_COMPILER_IS_DEFAULT` is set but never read. Why do we need it exactly?

Right, good you found that.

I first used it to determine whether the replacement in `LLDB_TEST_C/CXX_COMPILER` needs to be done in `lit/CMakeLists.txt`, but then it turned out the result is unused (since D54567 <https://reviews.llvm.org/D54567>, which is another verbose piece of history).
For reference please see: https://reviews.llvm.org/rL347216#change-H2HV4zA8ol05

It basically does what `LLDB_TEST_USE_CUSTOM_C/CXX_COMPILER` so far pretended to do (but in fact they were both broken). It somehow might makes sense to keep it as long as we have the manual string replacements in the dotest CMakeLists, even though the compiler paths are not used there (surprisingly). I will check why dotest doesn't need them and either fix it (which adds a use case) or remove it.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56440/new/

https://reviews.llvm.org/D56440