[Lldb-commits] [PATCH] D56425: [BreakpointList] Simplify/modernize BreakpointList (NFC)

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 8 14:09:48 PST 2019


JDevlieghere marked an inline comment as done.
JDevlieghere added a comment.

In D56425#1350234 <https://reviews.llvm.org/D56425#1350234>, @clayborg wrote:

> If we keep the list sorted we might be able to improve finding breakpoints by ID, but that can be done if we need to. BreakpointList::Add would need to insert it sorted, then we can get better than O(n) performance on FindBreakpointByID and Remove (anything that was using find_if when it is searching for a breakpoint by ID).


I'll do this as a follow-up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56425/new/

https://reviews.llvm.org/D56425





More information about the lldb-commits mailing list