[Lldb-commits] [PATCH] D56232: [lldb-server] Add remote platform capabilities for Windows
Zachary Turner via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Jan 7 10:08:47 PST 2019
zturner added a comment.
In D56232#1344652 <https://reviews.llvm.org/D56232#1344652>, @labath wrote:
> All of these functions seem identical to their PlatformPOSIX counterparts. Is that right? And I seem to remember already seeing a lot of code duplication between PlatformPOSIX and PlatformWindows.
> It sounds to me like we should create a new common base class for PlatformWindows and PlatformPOSIX (`RemoteAwarePlatform`?), and put the common code there.
Is that even necessary? If a platform is not remote aware, `IsHost()` will always just return `true` by definition. So we could put all of this in the existing `Platform` base class.
CHANGES SINCE LAST ACTION
More information about the lldb-commits