[Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.

Looks fine to me (but please wait for an ack from Zachary).



================
Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:313
 
-  for (lldb::tid_t tid = 0; tid < num_threads; ++tid) {
+  for (size_t t_index = 0; t_index < num_threads; ++t_index) {
     llvm::ArrayRef<uint8_t> context;
----------------
Since you're touching this, you might as well change this to a range-based for loop.


================
Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:316
+    const auto& thread = m_thread_list[t_index];
+    auto context_location = thread.thread_context;
+
----------------
LLVM tries to avoid `auto` overuse. For example, here I had to look up thread_context to see what type would this be. Could you put the actual type here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56293/new/

https://reviews.llvm.org/D56293