[Lldb-commits] [PATCH] D56231: [lldb-server] Improve support on Windows

[Hui Huang via Phabricator via lldb-commits]

Hui added a comment.

With all the aaron's pending reviews on lldb-server, I could try the patch with the following platform apis.

Seems to me is working on Windows and no regression on Linux side.  Some difference (performance) might be

(1) Previous, the vfile:write packet has a maximum as 1024 bytes, now it turns to 16384 byte from observations.
(2) FileSystem::Instance().Open will introduce some performance bumps however I think it is minor along with the ctor/dtor of the File

I think the python tests already cover the changes in this commit, especially for Linux.

Not applicable for Windows I think, since we need the availability of lldb-server.exe.

Remote:
./lldb-server.exe p --listen *:2000 --log-channels="lldb all:gdb-remote all:windows all"

LLDB:
platform select remote-windows
platform connect <URL>
file a.exe
r



================
Comment at: source/Host/common/File.cpp:607
     long cur = ::lseek(m_descriptor, 0, SEEK_CUR);
+    SeekFromStart(offset);
     error = Write(buf, num_bytes);
----------------
I think this line makes Windows equivalence since posix part is using 'pwrite' which means to write from a set offset in the file.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56231/new/

https://reviews.llvm.org/D56231