[Lldb-commits] [PATCH] D56115: [lldb] Check SafeToCallFunctions before calling functions in GetExceptionObjectForThread

[Kuba (Brecka) Mracek via Phabricator via lldb-commits]

kubamracek added a comment.

> I recently started writing these early-exit returns as return {};

Good suggestion!

> A testcase that triggers this situation would be nice, too.

I think this is too tricky. If I understand correctly, an example of an unsafe-to-call thread state is when we're parked inside a `__select` system call, and if we do invoke other code on that thread, sometimes, some kernel data structures can get out of sync from the thread state and the `__select` system call can sometimes return wrong results. Sounds quite hard to write a reliable test case for this, since the exact behavior also depends on OS version. I hope you'll forgive me for not providing this test :)


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56115/new/

https://reviews.llvm.org/D56115