[Lldb-commits] [PATCH] D56115: [lldb] Check SafeToCallFunctions before calling functions in GetExceptionObjectForThread

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 3 15:08:19 PST 2019


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

A testcase that triggers this situation would be nice, too.



================
Comment at: source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:558
+  if (!thread_sp->SafeToCallFunctions())
+    return ValueObjectSP();
+
----------------
I recently started writing these early-exit returns as `return {};`


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56115/new/

https://reviews.llvm.org/D56115





More information about the lldb-commits mailing list