[Lldb-commits] [PATCH] D56237: Implement GetFileLoadAddress for the Windows process plugin

Thu Jan 3 11:17:38 PST 2019

clayborg added a comment.

Seems like DynamicLoaderWindowsDYLD isn't doing its job correctly here and DynamicLoaderWindowsDYLD should be fixed. We shouldn't have to go to the process at all in order to set the section load addresses correctly. Why? As you might have seen lldb-server.exe is being worked on now and then we will have two clients for DynamicLoaderWindowsDYLD: the native ProcessWindows plug-in and ProcessGDBRemote. The

================
Comment at: source/Plugins/Process/Windows/Common/ProcessWindows.cpp:858

+Status ProcessWindows::GetFileLoadAddress(const FileSpec &file, bool &is_loaded,
+                                          lldb::addr_t &load_addr) {
----------------
This entire function is doing the job of the dynamic loader and should be moved into the dynamic loader.

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56237/new/

https://reviews.llvm.org/D56237