[Lldb-commits] [PATCH] D56173: Introduce SymbolFileBreakpad and use it to fill symtab

[Zachary Turner via lldb-commits]

Ok, lgtm then
On Wed, Jan 2, 2019 at 11:53 PM Pavel Labath <pavel at labath.sk> wrote:

> On 02/01/2019 18:32, Zachary Turner wrote:
> > Just to be sure, this new test will fail without your Symtab changes
> > right?  I'm not in a state where I can look at code right now, and you
> > say anything that symbolicates an address *can* use the symtab, but I
> > don't know if you really meant *must* use the symtab.
> >
>
> Yes, the test will fail without these changes. The reason I said "can"
> is because symtab is one of the sources of symbolication (the other is
> debug info for instance). However, in this case there is no other source
> of symbol information, so this information "must" come from the symtab
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190103/1014d401/attachment.html>