[Lldb-commits] [PATCH] D56231: [lldb-server] Improve support on Windows

[Aaron Smith via Phabricator via lldb-commits]

asmith created this revision.
asmith added reviewers: zturner, llvm-commits.
Herald added subscribers: lldb-commits, abidh.

This commit contains the following changes:

- Rewrite vfile close/read/write packet handlers with portable routines from lldb. This removes #if(s) and allows the handlers to work on Windows.
- Fix a bug in File::Write. This is intended to write data at an offset to a file but actually writes at the current position of the file.
- Add a default boolean argument 'should_close_fd' to FileSystem::Open to let the user decide whether to close the fd or not.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D56231

Files:
  include/lldb/Host/FileSystem.h
  source/Host/common/File.cpp
  source/Host/common/FileSystem.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56231.179963.patch
Type: text/x-patch
Size: 7383 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190103/e34be804/attachment.bin>