[Lldb-commits] [PATCH] D56173: Introduce SymbolFileBreakpad and use it to fill symtab

[Zachary Turner via lldb-commits]

Just to be sure, this new test will fail without your Symtab changes
right?  I'm not in a state where I can look at code right now, and you say
anything that symbolicates an address *can* use the symtab, but I don't
know if you really meant *must* use the symtab.

On Wed, Jan 2, 2019 at 12:19 AM Pavel Labath via Phabricator <
reviews at reviews.llvm.org> wrote:

> labath updated this revision to Diff 179819.
> labath added a comment.
>
> Add some "image lookup" commands to the test. The test now goes through
> lldb
> instead of lldb-test, but I've kept the lldb-test changes, as I think they
> make
> sense regardless. The tricky part about the new test is the need to
> specify the
> "target symbols add" command via '-o', because I need lit to substitute
> the full
> path to the symbol file.
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D56173/new/
>
> https://reviews.llvm.org/D56173
>
> Files:
>   lit/SymbolFile/Breakpad/Inputs/symtab.lldbinit
>   lit/SymbolFile/Breakpad/Inputs/symtab.syms
>   lit/SymbolFile/Breakpad/lit.local.cfg
>   lit/SymbolFile/Breakpad/symtab.yaml
>   source/API/SystemInitializerFull.cpp
>   source/Plugins/SymbolFile/Breakpad/CMakeLists.txt
>   source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp
>   source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.h
>   source/Plugins/SymbolFile/CMakeLists.txt
>   source/Symbol/SymbolVendor.cpp
>   tools/lldb-test/SystemInitializerTest.cpp
>   tools/lldb-test/lldb-test.cpp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20190102/b73bfbbb/attachment-0001.html>