[Lldb-commits] [PATCH] D55998: ELF: create "container" sections from PT_LOAD segments
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Dec 27 02:38:53 PST 2018
labath updated this revision to Diff 179541.
labath marked 4 inline comments as done.
labath added a comment.
Address review comments:
- move SegmentID() to the cpp file
- use lldb_private::Range (not lldb_utility::Range) for segment and sections ranges
- use brackets in segment names (PT_LOAD[0])
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55998/new/
https://reviews.llvm.org/D55998
Files:
lit/Modules/ELF/Inputs/PT_LOAD-overlap-section.elf
lit/Modules/ELF/PT_LOAD-empty.yaml
lit/Modules/ELF/PT_LOAD-overlap-PT_INTERP.yaml
lit/Modules/ELF/PT_LOAD-overlap-section.yaml
lit/Modules/ELF/PT_LOAD-overlap.yaml
lit/Modules/ELF/PT_LOAD.yaml
lit/Modules/ELF/section-overlap.yaml
lit/Modules/ELF/section-permissions.yaml
lit/Modules/ELF/section-types.yaml
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55998.179541.patch
Type: text/x-patch
Size: 21611 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181227/0a19aef5/attachment-0001.bin>
More information about the lldb-commits
mailing list