[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 21 07:16:37 PST 2018


clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

The changes from "constexpr" to "const" might introduce global constructors in the shared library which is what we were trying to avoid. The less work that the LLDB shared library does on load the better. We might need to use a macro that expands to "constexpr" for non windows and to "const" for windows in a private LLDB header (PropertyDefinition.h?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55995/new/

https://reviews.llvm.org/D55995





More information about the lldb-commits mailing list