[Lldb-commits] [PATCH] D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type and add GetCurrentExceptionBacktrace SB ABI

[Jim Ingham via Phabricator via lldb-commits]

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

That's great.  There are a couple places where you use self.assertEqual(..., False) where you can use self.assertFalse if you want.  A very minor point...



================
Comment at: packages/Python/lldbsuite/test/lang/objc/exceptions/TestObjCExceptions.py:47
+        # No exception being currently thrown/caught at this point
+        self.assertEqual(thread.GetCurrentException().IsValid(), False)
+        self.assertEqual(thread.GetCurrentExceptionBacktrace().IsValid(), False)
----------------
You can also say self.assertFalse here if you want.  Not very important.


================
Comment at: packages/Python/lldbsuite/test/lang/objc/exceptions/TestObjCExceptions.py:193
+        # C++ exceptions are not exposed in the API (yet).
+        self.assertEqual(thread.GetCurrentException().IsValid(), False)
+        self.assertEqual(thread.GetCurrentExceptionBacktrace().IsValid(), False)
----------------
Since you use assertTrue above, it would be more symmetrical to use self.assertFalse here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D44072/new/

https://reviews.llvm.org/D44072