[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Dec 19 10:26:39 PST 2018

clayborg added a comment.

In D55718#1336045 <https://reviews.llvm.org/D55718#1336045>, @tatyana-krasnukha wrote:

> `ARCflags` are used by ABISysV_arc (related patch D55724 <https://reviews.llvm.org/D55724>). I would be glad to move it to architecture plugin, but I ought to add SetFlags/GetFlags to Architecture interface in this case. Then we'll have the same members in ArchSpec and in Architecture, that may look confusing.

If the flags are used in other code, then leave them where they are. We can clean this up when a patch moves all flags out into Architecture headers eventually.

Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4707
+        arc::AdjustRegisterInfo(m_register_info, arch_to_use);
ok, makes sense. Clearing the register info would be a good idea. One extra question: why do we need to fix up this information? Does it come over incorrectly and in the XML data and then need to be fixed up? I would prefer to fix the data if possible so this doesn't have to be done. Another way to make things work when registers are incorrect is to specify a target definition file for GDB remote with:
(lldb) settings set plugin.process.gdb-remote.target-definition-file /path/to/regs.py




More information about the lldb-commits mailing list