[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

[Pavel Labath via Phabricator via lldb-commits]

labath added reviewers: aprantl, clayborg.
labath added a comment.

I think this fits well in the spirit in which the `enable-external-lookup` setting was introduced (i.e., to reduce test environment dependencies on mac), but the letter is somewhat questionable. The setting is currently described as "Control the use of external tools or libraries to locate symbol files.", which doesn't sound quite like what is happening here. I think this description rephrased to something more generic so that it covers this use case too. I'm not sure exactly how though. Maybe some blurb about not using "external resources" for symbols and then explaining that we consider /usr/lib/debug to be an external resource? Or maybe just outright confess that this does whatever it takes to make the lldb symbol lookup more predictable/hermetic?

+Adrian and Greg to see what they think about this.



================
Comment at: source/Host/common/Symbols.cpp:365
 
+  if (!external_lookup) {
+    Log *log = lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_HOST);
----------------
This doesn't sound right to me. It looks like this will prevent `LocateDSYMInVincinityOfExecutable`, which (I would expect) is necessary to find dsym bundles for all of our dsym tests.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55859/new/

https://reviews.llvm.org/D55859