[Lldb-commits] [PATCH] D55858: noexternal 1/2: refactor testsuite spawnLldbMi args->exe+args

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil marked 3 inline comments as done.
jankratochvil added a comment.

Thanks for the review!



================
Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/lldbmi_testcase.py:53
+        if exe:
+            self.runCmd("-file-exec-and-symbols \"%s\"" % exe)
 
----------------
labath wrote:
> Shouldn't you also expect the `^done` response here or something similar?
This would break compatibility with previous behavior of this function, see my `test_lldbmi_specialchars` comment below.


================
Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/syntax/TestMiSyntax.py:63
         self.expect("\^done")
 
         # Check that it was loaded correctly
----------------
Here you can see just by passing `complicated_myexe` as `spawnLldbMi` parameter the code still expects to be able to match the `-file-exec-and-symbols` command.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55858/new/

https://reviews.llvm.org/D55858