[Lldb-commits] [PATCH] D55854: Show the memory region name if there is one in the output of the "memory region" command

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Dec 19 00:04:23 PST 2018

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

This looks fine to me. I have one inline suggestion you can consider. Also, I've been wondering whether there is any existing minidump that you could have used for the test purposes. It doesn't sound like there is anything too special about this minidump, and it would reduce the number of binary blobs we carry around.

Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py:95-119
+        result = lldb.SBCommandReturnObject()
+        addr_region_name_pairs = [
+            ("0x400d9000", "/system/bin/app_process"),
+            ("0x400db000", "/system/bin/app_process"),
+            ("0x400dd000", "/system/bin/linker"),
+            ("0x400ed000", "/system/bin/linker"),
+            ("0x400ee000", "/system/bin/linker"),
wouldn't `self.expect` be able to handle this? I would expect this can just be a series of `self.expect("memory region XXX", substrs = ["/system/lib/whatever.so"])` commands.



More information about the lldb-commits mailing list