[Lldb-commits] [PATCH] D55841: GetMemoryRegions for the ProcessMinidump
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Dec 18 13:14:08 PST 2018
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Change looks good.
We need to add a test for this. You can use the minidump file from "lldb/unittests/Process/minidump/Inputs/regions-linux-map.dmp" and copy it over into "lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new" and then add a test to "packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py" to ensure this doesn't regress.
CHANGES SINCE LAST ACTION
More information about the lldb-commits