[Lldb-commits] [PATCH] D55837: [cmake] Make libcxx(abi) a dependency when building in-tree clang for macOS
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Dec 18 13:08:23 PST 2018
JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.
Comment at: CMakeLists.txt:160
list(APPEND LLDB_TEST_DEPS clang)
+ list(APPEND LLDB_TEST_DEPS cxx)
> What if the user wants to use a different compiler for tests? cmake has LLDB_TEST_USE_CUSTOM_C_COMPILER and LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER which can supposedly be set.
That still works. The change says that *if* you are going to build the in-tree clang, it has to build libcxx(abi) too. That should always make sense, because clang (on Darwin) won't be able to find the standard library otherwise.
CHANGES SINCE LAST ACTION
More information about the lldb-commits