[Lldb-commits] [lldb] r349539 - [cmake] Make libcxx(abi) a dependency when building in-tree clang for macOS

[Jonas Devlieghere via lldb-commits]

Author: jdevlieghere
Date: Tue Dec 18 12:59:23 2018
New Revision: 349539

URL: http://llvm.org/viewvc/llvm-project?rev=349539&view=rev
Log:
[cmake] Make libcxx(abi) a dependency when building in-tree clang for macOS

As discussed on IRC this morning, when building an in-tree clang for
testing we have to have libcxx and libcxxabi checked out. This is a
common pitfall. Not only are the resulting failures non-obvious, they
only manifest when running the test suite, *after* building lldb and
clang. By making them a hard dependency (on macOS) we fail earlier with
a more useful error message.

Differential revision: https://reviews.llvm.org/D55837

Modified:
    lldb/trunk/CMakeLists.txt

Modified: lldb/trunk/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/CMakeLists.txt?rev=349539&r1=349538&r2=349539&view=diff
==============================================================================
--- lldb/trunk/CMakeLists.txt (original)
+++ lldb/trunk/CMakeLists.txt Tue Dec 18 12:59:23 2018
@@ -157,6 +157,10 @@ if(LLDB_INCLUDE_TESTS)
 
   if(TARGET clang)
     list(APPEND LLDB_TEST_DEPS clang)
+    if(APPLE)
+      list(APPEND LLDB_TEST_DEPS cxx)
+      list(APPEND LLDB_TEST_DEPS cxxabi)
+    endif()
   endif()
 
   if(TARGET dsymutil)