[Lldb-commits] [lldb] r349482 - Un-XFail TestThreadStates.test_process_interrupt

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 18 05:32:42 PST 2018


Author: labath
Date: Tue Dec 18 05:32:42 2018
New Revision: 349482

URL: http://llvm.org/viewvc/llvm-project?rev=349482&view=rev
Log:
Un-XFail TestThreadStates.test_process_interrupt

This test is passing now on linux. The same test is claimed to be flaky
on darwin, so it's possible that's true on linux too. If that's the case
we'll have to skip it here too (or fix it).

I mark the test as not-debug-info-dependent as a drive-by.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/state/TestThreadStates.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/state/TestThreadStates.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/state/TestThreadStates.py?rev=349482&r1=349481&r2=349482&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/state/TestThreadStates.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/state/TestThreadStates.py Tue Dec 18 05:32:42 2018
@@ -52,17 +52,6 @@ class ThreadStateTestCase(TestBase):
         self.thread_state_after_expression_test()
 
     # thread states not properly maintained
-    @unittest2.expectedFailure("llvm.org/pr16712")
-    @expectedFailureAll(
-        oslist=["windows"],
-        bugnumber="llvm.org/pr24668: Breakpoints not resolved correctly")
-    @skipIfDarwin # llvm.org/pr15824 thread states not properly maintained and <rdar://problem/28557237>
-    def test_process_interrupt(self):
-        """Test process interrupt."""
-        self.build(dictionary=self.getBuildFlags(use_cpp11=False))
-        self.process_interrupt_test()
-
-    # thread states not properly maintained
     @unittest2.expectedFailure("llvm.org/pr15824 and <rdar://problem/28557237>")
     @expectedFailureAll(
         oslist=["windows"],
@@ -198,8 +187,14 @@ class ThreadStateTestCase(TestBase):
         # Let the process run to completion
         self.runCmd("process continue")
 
-    def process_interrupt_test(self):
+    @expectedFailureAll(
+        oslist=["windows"],
+        bugnumber="llvm.org/pr24668: Breakpoints not resolved correctly")
+    @skipIfDarwin # llvm.org/pr15824 thread states not properly maintained and <rdar://problem/28557237>
+    @no_debug_info_test
+    def test_process_interrupt(self):
         """Test process interrupt and continue."""
+        self.build(dictionary=self.getBuildFlags(use_cpp11=False))
         exe = self.getBuildArtifact("a.out")
         self.runCmd("file " + exe, CURRENT_EXECUTABLE_SET)
 




More information about the lldb-commits mailing list