[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

[Tatyana Krasnukha via Phabricator via lldb-commits]

tatyana-krasnukha marked 2 inline comments as done.
tatyana-krasnukha added a comment.

My intent was to move ARC-specific code to the architecture plugin as much as possible, but it requires to add undesired dependencies to Architecture interface. So, you are right, it seems to be better to keep these functions in ProcessGDBRemote.cpp and remove ArcArchitecture plugin at all.



================
Comment at: include/lldb/Core/Architecture.h:15
 
+class DynamicRegisterInfo;
+
----------------
clayborg wrote:
> Is DynamicRegisterInfo really in the top level namespace?
Yes, it is, just double-checked


================
Comment at: source/Target/Target.cpp:74
   m_spec = spec;
-  m_plugin_up = PluginManager::CreateArchitectureInstance(spec);
+  m_plugin_up = PluginManager::CreateArchitectureInstance(m_spec);
   return *this;
----------------
clayborg wrote:
> is this change needed?
These 2 changes were needed because ArcArchitecture held a reference to m_spec


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55718/new/

https://reviews.llvm.org/D55718