[Lldb-commits] [PATCH] D55574: Remove else statements after returns

[Zachary Turner via Phabricator via lldb-commits]

zturner added inline comments.


================
Comment at: source/Commands/CommandObjectTarget.cpp:2569
+          }
+          StreamString strm;
+          module_spec.GetUUID().Dump(&strm);
----------------
aprantl wrote:
> Can you manually double-check this one?
For large complex cases like this, it might make sense to convert them to early returns first.  That makes the size of the if blocks smaller so less chance of messing up.


================
Comment at: source/Commands/CommandObjectTarget.cpp:2601-2607
+      } else {
+        result.AppendError(
+            "one or more executable image paths must be specified");
+        result.SetStatus(eReturnStatusFailed);
+        return false;
+      }
       } else {
----------------
Something is wrong with indentation here.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55574/new/

https://reviews.llvm.org/D55574