[Lldb-commits] [PATCH] D55727: Add "dump" command as a custom "process plugin" subcommand when ProcessMinidump is used.

[Leonard Mosescu via Phabricator via lldb-commits]

lemo accepted this revision.
lemo added a comment.
This revision is now accepted and ready to land.

I love the idea of custom dump commands, thanks Greg.

The changes look good to me (I agree with Zach suggestion to add lit tests)



================
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:706
+  }
+  return "???";
+}
----------------
use a more explicit text, ex "unknown stream type" ?


================
Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:495
+public:
+#define INIT_BOOL(VAR, LONG, SHORT, DESC) \
+    VAR(LLDB_OPT_SET_1, false, LONG, SHORT, DESC, false, true)
----------------
I'm not a fan of "embedded" macro definitions - it may suggests that they are scope bound why they are not. I'd move them above the class definition.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55727/new/

https://reviews.llvm.org/D55727