[Lldb-commits] [lldb] r349122 - Fix test failures that depended on module order

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 13 19:07:16 PST 2018


Author: gclayton
Date: Thu Dec 13 19:07:15 2018
New Revision: 349122

URL: http://llvm.org/viewvc/llvm-project?rev=349122&view=rev
Log:
Fix test failures that depended on module order

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
    lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump/TestMiniDump.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py?rev=349122&r1=349121&r2=349122&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py Thu Dec 13 19:07:15 2018
@@ -97,14 +97,18 @@ class MiniDumpNewTestCase(TestBase):
         self.assertTrue(self.process, PROCESS_IS_VALID)
         expected_modules = [
             {
-                'filename' : 'linux-gate.so',
-                'uuid' : '4EAD28F8-88EF-3520-872B-73C6F2FE7306-C41AF22F',
+                'filename' : 'linux-x86_64',
+                'uuid' : 'E35C283B-C327-C287-62DB-788BF5A4078B-E2351448',
             },
             {
                 'filename' : 'libm-2.19.so',
                 'uuid' : 'D144258E-6149-00B2-55A3-1F3FD2283A87-8670D5BC',
             },
             {
+                'filename' : 'libgcc_s.so.1',
+                'uuid' : '36311B44-5771-0AE5-578C-4BF00791DED7-359DBB92',
+            },
+            {
                 'filename' : 'libstdc++.so.6.0.19',
                 'uuid' : '76190E92-2AF7-457D-078F-75C9B15FA184-E83EB506',
             },
@@ -113,24 +117,20 @@ class MiniDumpNewTestCase(TestBase):
                 'uuid' : 'CF699A15-CAAE-64F5-0311-FC4655B86DC3-9A479789',
             },
             {
-                'filename' : 'linux-x86_64',
-                'uuid' : 'E35C283B-C327-C287-62DB-788BF5A4078B-E2351448',
-            },
-            {
-                'filename' : 'libgcc_s.so.1',
-                'uuid' : '36311B44-5771-0AE5-578C-4BF00791DED7-359DBB92',
-            },
-            {
                 'filename' : 'libpthread-2.19.so',
                 'uuid' : '31E9F21A-E8C1-0396-171F-1E13DA157809-86FA696C',
             },
             {
+                'filename' : 'libbreakpad.so',
+                'uuid' : '784FD549-332D-826E-D23F-18C17C6F320A',
+            },
+            {
                 'filename' : 'ld-2.19.so',
                 'uuid' : 'D0F53790-4076-D73F-29E4-A37341F8A449-E2EF6CD0',
             },
             {
-                'filename' : 'libbreakpad.so',
-                'uuid' : '784FD549-332D-826E-D23F-18C17C6F320A',
+                'filename' : 'linux-gate.so',
+                'uuid' : '4EAD28F8-88EF-3520-872B-73C6F2FE7306-C41AF22F',
             },
         ]
         self.assertEqual(self.target.GetNumModules(), len(expected_modules))

Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump/TestMiniDump.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump/TestMiniDump.py?rev=349122&r1=349121&r2=349122&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump/TestMiniDump.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump/TestMiniDump.py Thu Dec 13 19:07:15 2018
@@ -50,28 +50,28 @@ class MiniDumpTestCase(TestBase):
         self.assertTrue(self.process, PROCESS_IS_VALID)
         expected_modules = [
             {
-                'filename' : r"C:\Windows\System32/MSVCP120D.dll",
-                'uuid' : '6E51053C-E757-EB40-8D3F-9722C5BD80DD-01000000',
-            },
-            {
-                'filename' : r"C:\Windows\SysWOW64/kernel32.dll",
-                'uuid' : '1B7ECBE5-5E00-1341-AB98-98D6913B52D8-02000000',
-            },
-            {
                 'filename' : r"C:\Users\amccarth\Documents\Visual Studio 2013\Projects\fizzbuzz\Debug/fizzbuzz.exe",
                 'uuid' : '91B7450F-969A-F946-BF8F-2D6076EA421A-11000000',
             },
             {
-                'filename' : r"C:\Windows\System32/MSVCR120D.dll",
-                'uuid' : '86FB8263-C446-4640-AE42-8D97B3F91FF2-01000000',
+                'filename' : r"C:\Windows\SysWOW64/ntdll.dll",
+                'uuid' : '6A84B0BB-2C40-5240-A16B-67650BBFE6B0-02000000',
+            },
+            {
+                'filename' : r"C:\Windows\SysWOW64/kernel32.dll",
+                'uuid' : '1B7ECBE5-5E00-1341-AB98-98D6913B52D8-02000000',
             },
             {
                 'filename' : r"C:\Windows\SysWOW64/KERNELBASE.dll",
                 'uuid' : '4152F90B-0DCB-D44B-AC5D-186A6452E522-01000000',
             },
             {
-                'filename' : r"C:\Windows\SysWOW64/ntdll.dll",
-                'uuid' : '6A84B0BB-2C40-5240-A16B-67650BBFE6B0-02000000',
+                'filename' : r"C:\Windows\System32/MSVCP120D.dll",
+                'uuid' : '6E51053C-E757-EB40-8D3F-9722C5BD80DD-01000000',
+            },
+            {
+                'filename' : r"C:\Windows\System32/MSVCR120D.dll",
+                'uuid' : '86FB8263-C446-4640-AE42-8D97B3F91FF2-01000000',
             },
         ]
         self.assertEqual(self.target.GetNumModules(), len(expected_modules))




More information about the lldb-commits mailing list