[Lldb-commits] [PATCH] D55582: [Reproducers] Add command reproducer

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

I played around with this today:

- I'm totally convinced that we should replay by swapping out stdin with a file from the reproducer. This makes this better overall.
- I'm not convinced that capturing just stdin is an improvement. What I like about the current approach is that we don't have to bother with the `-o`/`-S` commands when replaying. We already have a mechanism to deal with them so I don't think it's unreasonable to piggyback on it, especially because this is how we display it to the user. On the other hand, I generally try to keep the code path the same between the regular and reproducer case, and processing the command line options in the reproducer case would reuse more of the existing code. Finally, we'd have to figure out a way to test this, because currently we rely on the commands provided/sourced through the command line to test the replay. How would we test this functionality when only capturing from stdin?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55582/new/

https://reviews.llvm.org/D55582