[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

Thu Dec 13 11:02:37 PST 2018

aprantl added inline comments.
Herald added a subscriber: michaelplatings.

================
Comment at: cmake/modules/LLDBConfig.cmake:275
-if (CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR)
-  message(FATAL_ERROR "In-source builds are not allowed. CMake would overwrite "
-"the makefiles distributed with LLDB. Please create a directory and run cmake "
----------------
We should keep this warning, but just say that in-tree builds are not supported. There is no bot testing this and we don't want to bother with keeping this config work.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55328/new/

https://reviews.llvm.org/D55328