[Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 13 07:26:43 PST 2018

labath added a comment.

The test looks really good now.

This looks fine to me, though I don't know much about PBDs. I still think the seemingly random change in `BinaryStreamArray` would be better served as a standalone patch.

Comment at: lldb/lit/SymbolFile/NativePDB/Inputs/local-variables.lldbinit:19-22
+p Param1
+p Param2
+p Local1
+p Local2
I am not sure if you care about the distinction between "expr" and "frame variable" here, but if you don't, these could be displayed in one shot with `frame variable Param1 Param2 Local1 Local2` (or even just `frame variable` which would display all locals).

Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:1929
+#include "lldb/Target/MemoryRegionInfo.h"
zturner wrote:
> labath wrote:
> > Huh?
> Oops :-/
It looks like you still haven't removed this.



More information about the lldb-commits mailing list