[Lldb-commits] [lldb] r348951 - NFC: fix compiler warning about code never being executed when compiling on non windows platform.

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Wed Dec 12 10:14:27 PST 2018


Author: gclayton
Date: Wed Dec 12 10:14:27 2018
New Revision: 348951

URL: http://llvm.org/viewvc/llvm-project?rev=348951&view=rev
Log:
NFC: fix compiler warning about code never being executed when compiling on non windows platform.


Modified:
    lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp

Modified: lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp?rev=348951&r1=348950&r2=348951&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp Wed Dec 12 10:14:27 2018
@@ -78,12 +78,13 @@ bool ShouldAddLine(uint32_t requested_li
 } // namespace
 
 static bool ShouldUseNativeReader() {
-#if !defined(_WIN32)
-  return true;
-#endif
+#if defined(_WIN32)
   llvm::StringRef use_native = ::getenv("LLDB_USE_NATIVE_PDB_READER");
   return use_native.equals_lower("on") || use_native.equals_lower("yes") ||
          use_native.equals_lower("1") || use_native.equals_lower("true");
+#else
+  return true;
+#endif
 }
 
 void SymbolFilePDB::Initialize() {




More information about the lldb-commits mailing list