[Lldb-commits] [PATCH] D55574: Remove else statements after returns

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added a comment.

I'm mostly on board with making these changes, as it's good LLVM style to do this. I highlighted a couple changes that might warrant a closer look.



================
Comment at: source/API/SBProcess.cpp:1233
     error.SetErrorString("process is invalid");
   }
+
----------------
This function probably could use some manual refactoring, too.


================
Comment at: source/Commands/CommandObjectTarget.cpp:2569
+          }
+          StreamString strm;
+          module_spec.GetUUID().Dump(&strm);
----------------
Can you manually double-check this one?


================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3818
+            static_cast<void *>(namespace_decl->getOriginalNamespace()));
+      }
       }
----------------
what's going on here with the indentation?


================
Comment at: source/Target/Process.cpp:1930
+            error.AsCString() ? error.AsCString() : "unknown error");
+      }
+      }
----------------
this also looks suspicious


================
Comment at: source/Target/Process.cpp:5235
+                  event_to_broadcast_sp, options, handle_interrupts);
+            }
             } break;
----------------
wouldn't hurt to manually check this one, too


================
Comment at: source/Target/ThreadPlanStepRange.cpp:329
+      run_to_address.Slide(last_inst_size);
+    }
     } else if (branch_index - pc_index > 1) {
----------------
weird indentation again


================
Comment at: source/Target/ThreadPlanStepUntil.cpp:246
         }
-      }
-      // If we get here we haven't hit any of our breakpoints, so let the
-      // higher plans take care of the stop.
-      m_explains_stop = false;
-      return;
-    } else if (IsUsuallyUnexplainedStopReason(reason)) {
+        }
+
----------------
again


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55574/new/

https://reviews.llvm.org/D55574