[Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

A couple of small comments, but it looks good otherwise. Thanks!



================
Comment at: lit/BuildScript/toolchain-clang.test:1
+RUN: %build -n --verbose --arch=32 --compiler=clang --mode=compile-and-link -o %t/foo.exe foobar.c \
+RUN:    | FileCheck --check-prefix=CHECK --check-prefix=CHECK-32 %s
----------------
There are a couple of tests for the build script that we should enable on non-windows as well:
* script-args
* modes
Both should pass with your change


================
Comment at: lit/helper/build.py:627
+        elif self.opt == 'lto':
+            raise NotImplementedError("LTO not implemented in gcc builder")
+        if self.nodefaultlib:
----------------
You can just add the thinlto command here. That should give you parity with the msvc builder:

            args.append('-flto=thin')





CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55430/new/

https://reviews.llvm.org/D55430