[Lldb-commits] [PATCH] D55422: Rename ObjectFile::GetHeaderAddress to GetBaseAddress
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Dec 11 07:21:47 PST 2018
labath marked 2 inline comments as done.
labath added inline comments.
================
Comment at: source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1677
// Check to see if the module was read from memory?
- if (module_sp->GetObjectFile()->GetHeaderAddress().IsValid()) {
+ if (module_sp->GetObjectFile()->GetBaseAddress().IsValid()) {
// We have a module that is in memory and needs to have its file
----------------
clayborg wrote:
> Switching to IsInMemory will work. This code probably predates the existence of IsInMemory().
Ok, I'll check this in separately, as this is the only functional change in this commit.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55422/new/
https://reviews.llvm.org/D55422
More information about the lldb-commits
mailing list