[Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

This looks fine to me. The test is a bit more coarse-grained than I'd like, though I can't think of a substantially better approach right now. One of the pdb folks should ok this too.



================
Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:386
 
-  for (lldb::tid_t tid = 0; tid < num_threads; ++tid) {
+  for (lldb::tid_t t_index = 0; t_index < num_threads; ++t_index) {
     llvm::ArrayRef<uint8_t> context;
----------------
Since you're changing this, you might as well change the type to something more appropriate (size_t?).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55142/new/

https://reviews.llvm.org/D55142