[Lldb-commits] [PATCH] D55472: Speadup memory regions handling and cleanup related code
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Dec 10 10:40:52 PST 2018
clayborg added inline comments.
================
Comment at: include/lldb/API/SBMemoryRegionInfoList.h:31
- bool GetMemoryRegionAtIndex(uint32_t idx, SBMemoryRegionInfo ®ion_info);
+ void Reserve(size_t capacity);
----------------
zturner wrote:
> clayborg wrote:
> > This you can add, but std::vector implementations are quite efficient and I doubt this is really needed?
> std::vector is as efficient as it can be without additional hints from the user, but reserve is a very useful optimization in general.
Agreed but this doesn't need to be in the public API as there is no real need.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55472/new/
https://reviews.llvm.org/D55472
More information about the lldb-commits
mailing list