[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

Mon Dec 10 09:05:50 PST 2018

labath added a comment.

In D55384#1323464 <https://reviews.llvm.org/D55384#1323464>, @zturner wrote:

> I considered this, and we actually have a test that does (see `s_constant.s`).  The reason I didn't do it here because my experience writing `s_constant.s` taught me just how difficult it is to write these assembly files.
>
> However, now I have a new idea.  We can teach `llvm-pdbutil` to dump its output exactly in llvm assembly format, so the output can just be copy-pasted into a .s file.  Then, we can build something with MSVC, dump it to .s format, and paste individual records into a test and mix and match them as necessary to create all the interesting cases.
>
> For the purposes of this test, we don't even need to run the program, so it actually doesn't even matter if the addresses in the debug info records are correct.  All we care about is that the AST is reconstructed correctly.  I'll add this to my todo list because I think it would be a really useful feature.

That sounds like a really useful feature.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55384/new/

https://reviews.llvm.org/D55384