[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

Stefan Gränitz via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Dec 7 09:06:24 PST 2018


sgraenitz marked an inline comment as done.
sgraenitz added inline comments.


================
Comment at: cmake/modules/LLDBConfig.cmake:64
+  set(LLVM_CODESIGNING_IDENTITY lldb_codesign CACHE STRING "" FORCE)
+endif()
+
----------------
@labath Could this be a way to phase out LLDB_CODESIGN_IDENTITY and move to the LLVM one?

* An **explicitly set** LLDB value takes precedence
* Warn if a non-empty LLVM value is overwritten
* Default to lldb_codesign if none is set explicitly


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55328/new/

https://reviews.llvm.org/D55328





More information about the lldb-commits mailing list