[Lldb-commits] [PATCH] D55422: Rename ObjectFile::GetHeaderAddress to GetBaseAddress

[Greg Clayton via Phabricator via lldb-commits]

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Looks fine. Just one clarification in the header documentation and this is good to go.



================
Comment at: include/lldb/Symbol/ObjectFile.h:561
+  /// will have this section set. Otherwise, the address will just have the
+  /// offset member filled in.
   //------------------------------------------------------------------
----------------
```
/// offset member filled in indicating the resulting Address object represents a file address.
```


================
Comment at: source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1677
       // Check to see if the module was read from memory?
-      if (module_sp->GetObjectFile()->GetHeaderAddress().IsValid()) {
+      if (module_sp->GetObjectFile()->GetBaseAddress().IsValid()) {
         // We have a module that is in memory and needs to have its file
----------------
Switching to IsInMemory will work. This code probably predates the existence of IsInMemory().


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55422/new/

https://reviews.llvm.org/D55422