[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

[Stefan Gränitz via Phabricator via lldb-commits]

sgraenitz added a comment.

Thanks for taking a look!

> It's not introduced in this patch, but the part that struck me as a hack has the force-overwriting of LLVM_CODESIGNING_IDENTITY. Is there any way that could be removed?

I agree, this is unfortunate. The problem is that we only have a single global setting for the identity in LLVM and we want `lldb_codesign` as the default for LLDB. We can only change this default if we use a cache script or pass it to CMake explicitly, but at the time we arrive in LLDBConfig it's set already. So to make it work out-of-the-box we need the force-overwrite.

Actually, I considered changing the `llvm_codesign` function to accept an override value for the identity and pass it through `lldb_add_executable`/`llvm_add_executable` per target. In the end the use-case didn't really seem worth the amount of change. Also, overriding a global `LLVM_CODESIGNING_IDENTITY` with a default value might be very confusing. I considered a LLDB-specific version as well (D54352 <https://reviews.llvm.org/D54352>), but with the amount of code duplication @beanz was definitely right that this is not a good way either.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55328/new/

https://reviews.llvm.org/D55328