[Lldb-commits] [PATCH] D55318: [Expressions] Add support of expressions evaluation in some object's context

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 6 16:52:11 PST 2018


jingham added inline comments.


================
Comment at: include/lldb/API/SBValue.h:310-312
+  lldb::SBValue EvaluateExpression(const char *expr) const;
+  lldb::SBValue EvaluateExpression(const char *expr,
+                                   const SBExpressionOptions &options) const;
----------------
zturner wrote:
> Can you use `StringRef` instead of `const char *` here?
This is an SB API.  We don't use StringRef's or any other llvm data types in the SB API's.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55318/new/

https://reviews.llvm.org/D55318





More information about the lldb-commits mailing list