[Lldb-commits] [PATCH] D55399: If we still have all_image_infos use it in DynamicLoaderMacOSDYLD to detect exec's

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 6 16:40:30 PST 2018


jingham marked 2 inline comments as done.
jingham added inline comments.


================
Comment at: source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp:83
+      m_break_id(LLDB_INVALID_BREAK_ID), m_mutex()
+      , m_maybe_image_infos_address(LLDB_INVALID_ADDRESS) {}
 
----------------
aprantl wrote:
> Why not just write C++11-style `= LLDB_INVALID_ADDRESS` in the declaration?
I think it's confusing to have some declaration initialization and some constructor initialization, and I didn't want to change this class over to all initialization as it would add noise to the patch.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55399/new/

https://reviews.llvm.org/D55399





More information about the lldb-commits mailing list