[Lldb-commits] [lldb] r348527 - [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

Jason Molenda via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 6 14:44:20 PST 2018

Hi Aaron, this is failing to build on macOS systems --

> On Dec 6, 2018, at 1:36 PM, Aaron Smith via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> +    // At this moment we only have the base name of the DLL. The full path can
> +    // only be seen after the dynamic loading.  Our best guess is Try to get it
> +    // with the help of the object file's directory.
> +    llvm::SmallString<MAX_PATH> dll_fullpath;
> +    FileSpec dll_specs(dll_name);
> +    dll_specs.GetDirectory().SetString(m_file.GetDirectory().GetCString());
> +

We don't have a MAX_PATH on Darwin systems, but we do have a PATH_MAX which is used in other parts of lldb.  Does PATH_MAX work on windows?

More information about the lldb-commits mailing list