[Lldb-commits] [PATCH] D55384: [NativePDB] Reconstruct FunctionDecl AST nodes from PDB debug info

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Dec 6 13:38:12 PST 2018


zturner updated this revision to Diff 177039.
zturner added a comment.

Clang-cl emits `S_LOCAL` symbols while MSVC emits `S_REGREL32` and `S_REGISTER` symbols.  So, to get more test coverage, I added an MSVC test as well.  Also a little NFC cleanup in the main source file (basically just making sure these decls get added to the decl map).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55384/new/

https://reviews.llvm.org/D55384

Files:
  lldb/lit/SymbolFile/NativePDB/Inputs/ast-functions.lldbinit
  lldb/lit/SymbolFile/NativePDB/Inputs/ast-reconstruction.lldbinit
  lldb/lit/SymbolFile/NativePDB/Inputs/ast-types.lldbinit
  lldb/lit/SymbolFile/NativePDB/ast-functions-msvc.cpp
  lldb/lit/SymbolFile/NativePDB/ast-functions.cpp
  lldb/lit/SymbolFile/NativePDB/ast-reconstruction.cpp
  lldb/lit/SymbolFile/NativePDB/ast-types.cpp
  lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
  lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h
  llvm/include/llvm/DebugInfo/CodeView/SymbolRecordHelpers.h
  llvm/include/llvm/Support/BinaryStreamArray.h
  llvm/lib/DebugInfo/CodeView/SymbolRecordHelpers.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55384.177039.patch
Type: text/x-patch
Size: 10638 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181206/ba8136c7/attachment.bin>


More information about the lldb-commits mailing list