[Lldb-commits] [PATCH] D55361: Move Broadcaster+Listener+Event combo from Core into Utility

[Raphael Isemann via Phabricator via lldb-commits]

teemperor added a comment.

LGTM modulo the unrelated clang-format changes. Feel free to commit them separately (even though the `m_event_names` fix looks a bit strange).



================
Comment at: include/lldb/Utility/Broadcaster.h:551
 
-    Broadcaster &m_broadcaster;    ///< The broadcaster that this implements
-    event_names_map m_event_names; ///< Optionally define event names for
----------------
What was changed here? I assume clang-format fallout, so can we drop this?


================
Comment at: source/Utility/Broadcaster.cpp:229
-    if (unique &&
-        hijacking_listener_sp->PeekAtNextEventForBroadcasterWithType(
-            &m_broadcaster, event_type))
----------------
Also unrelated.


================
Comment at: source/Utility/Broadcaster.cpp:239
-          pair.first->PeekAtNextEventForBroadcasterWithType(&m_broadcaster,
-                                                            event_type))
         continue;
----------------
Also unrelated.


================
Comment at: source/Utility/Event.cpp:139
   else
-    s->Format("{0:$[ ]@[x-2]}", llvm::make_range(
-                         reinterpret_cast<const uint8_t *>(m_bytes.data()),
----------------
Also unrelated it seems.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55361/new/

https://reviews.llvm.org/D55361