[Lldb-commits] [PATCH] D55214: Introduce ObjectFileBreakpad

[Mark Mentovai via Phabricator via lldb-commits]

markmentovai added inline comments.


================
Comment at: source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.h:74
+
+  bool IsStripped() override { return false; }
+
----------------
labath wrote:
> zturner wrote:
> > Is this always true for breakpad files?
> Well.. the whole point of these files is to provide symbol information, so it would be weird if they were stripped. The breakpad `dump_syms` allows you to omit generating unwind information, but I don't think that's enough to call this "stripped". It is certainly possible to create a file by hand which contains just a `MODULE` directive and nothing else, but I would say that is a (non-stripped) file which describes an empty module, and not a stripped file.
> 
> In reality, this doesn't really matter, as this function is called from just one place <https://github.com/llvm-mirror/lldb/blob/master/source/Core/Module.cpp#L506>, and I don't think that will be relevant for breakpad files.
Correct, "stripped" isn't really useful for Breakpad dump_syms output. What does LLDB do with the result of IsStripped()?

Stripped dump_syms output would be what you get from running dump_syms on a stripped module. I can't imagine why anyone would do this intentionally, but you'd also be hard-pressed to tell that's what had happened given only the dumped symbol file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55214/new/

https://reviews.llvm.org/D55214