[Lldb-commits] [PATCH] D54670: .debug_types: Update of D32167 on top of D51578 (.debug_types section concatenation)

Tue Dec 4 09:48:02 PST 2018

jankratochvil added a comment.

@clayborg You have already approved this patchset merged with D51578 <https://reviews.llvm.org/D51578> in D51578 three weeks ago <https://reviews.llvm.org/D51578#1295725>. I have split it afterwards to:

| 1of2 | D51578 <https://reviews.llvm.org/D51578>      | the section merge which you have approved; but it is not much useful without any code using it.                                                                                                                |
| 2of2 | this D54670 <https://reviews.llvm.org/D54670> | your original `.debug_types` patch but with my added few lines of code <https://reviews.llvm.org/D54670#1302199> to fix its regression when using `.debug_types`.  These few lines have not been approved yet. |
|

Should I check it in as you wrote it or is it OK with those few lines of code added by me?

Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54670/new/

https://reviews.llvm.org/D54670